-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki: remove live option for logs panel #19533
Conversation
@davkal We should probably also change the log panel docs too as they mention the live option. Otherwise looks good. |
Hmm also what will happen if user sets something live and then updates? Probably no way to turn it back off, only recreating the whole panel. |
Another good point, I'm happy to live with this for now. |
…uery * grafana/master: (26 commits) Loki: remove live option for logs panel (grafana#19533) Chore: Updates to 6.4.0 stable (grafana#19528) CloudWatch: Add ap-east-1 to hard-coded region lists (grafana#19523) ChangeLog: Release 6.4.0 Stable (grafana#19526) Docs: Add notice about plugins that need updating (grafana#19519) Panels: Skip re-rendering panel/visualisation in loading state (grafana#19518) Docs: LDAP Debug View documentation (grafana#19513) Docs: reports feature (grafana#19472) SeriesOverrides: Fixed issue with color picker Build: Fix building when $LDFLAGS is set (grafana#19509) API: Add `createdAt` and `updatedAt` to api/users/lookup (grafana#19496) Fix logs panel image path Logs: Publish logs panel (grafana#19504) Explore: Update broken link to logql docs (grafana#19510) Chore: Remove console.log (grafana#19412) Refactor: Split LogRow component (grafana#19471) Build: Upgrade go to 1.12.10 (grafana#19499) CLI: Fix version selection for plugin install (grafana#19498) Upgrade grafana-plugin-model (grafana#19438) grafana-ui: Moves slate types from devDependencies to dependencies (grafana#19470) ...
* Loki: remote live option for logs panel * Remove live from logs panel docs (cherry picked from commit 942f702)
* Loki: remote live option for logs panel * Remove live from logs panel docs (cherry picked from commit 942f702)
The live feature was awesome, any plan integrating this again? :) |
I'm forced to stay at 6.4.1 because of this |
The live feature is still available in Explore. It was a bit unstable in logs panels so we'd like to learn a bit more about the problems. |
Ah ok I see. I only used it through Grafana Explore and it always worked fine, never used the live feature in a Panel. I thought this ticket would also remove this from Explore. |
@davkal Biggest issues for me are the panel seemingly losing connection at times and not automatically scrolling to new logs when display order is in descending mode |
* Loki: remote live option for logs panel * Remove live from logs panel docs (cherry picked from commit 942f702)
The live tailing option was removed with grafana#19533 per some outstanding issues (grafana#19532 and grafana#19530). It should no be mentioned in the docs as a feature. grafana#19533
The Grafana docs still say this is possible. Pulled my hair out looking for the option. Just submitted PR #22704 to update docs. Not sure if this is the place to discuss use cases, but we would definitely like this back. It's part of why I set up Loki in the first place. To the comment that it will be out of sync with the rest of the dashboard, that's expected. But if I have a realtime metrics board refreshing every 1s, with a grafana log panel by some other metrics, I can watch the CPU use of loki spike to meet the demand. It instead I do a live tail in explore, the cpu use of loki is practically 0 and i get my live tail. TLDR its still useful for realtime dashes and hope it can be brought back. |
The live option for Loki in the logs panels caused a couple of issues:
This PR is a quick-fix to prevent live panel related issues from impacting too many people.
Speaking to the Loki team, they don't see a use for a live option in the dashboards to begin with, since it will be out of sync with the rest of the dashboard.