Profile: Fix issue with user profile not showing more than sessions sessions in some cases #19578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
torkelo
reviewed
Oct 2, 2019
huynhsamha
commented
Oct 2, 2019
|
strange, unable to replicate this problem |
|
@torkelo was able to reproduce on play.grafana.org. Login, then open https://play.grafana.org/d/000000012/grafana-play-home?orgId=1 abd then navigate to your profile page via sidenav.
|
torkelo
approved these changes
Oct 3, 2019
torkelo
changed the title
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Oct 4, 2019
…uery * grafana/master: (28 commits) Revert "Feature: Adds connectWithCleanup HOC (grafana#19392)" (grafana#19628) Feature: Adds connectWithCleanup HOC (grafana#19392) Panels: Progress on new singlestat / BigValue (grafana#19374) Units: fixed wrong id for Terabits/sec (grafana#19611) Docs: General improvements to docs, and a fix in oauth (grafana#19587) Docs: Replace ampersands with and (grafana#19609) Profile: Fix issue with user profile not showing more than sessions some times (grafana#19578) Azure Monitor : Query more than 10 dimensions ( Fixes grafana#17230 ) (grafana#18693) Login: Show SAML login button if SAML is enabled (grafana#19591) UI: Adds Modal component (grafana#19369) Prometheus: Fixes so results in Panel always are sorted by query order (grafana#19597) Docs: Improve guides for contributing (grafana#19575) Migration: Migrates Admin settings from angular to react (grafana#19594) Chore: Converts HelpModal from angular to react (grafana#19474) Fix typo (grafana#19571) Chore: Upgrade to Go 1.13 (grafana#19502) Explore: Move data source loader into the select (grafana#19465) Theme: fixed issue with theme always beeing modified (grafana#19517) Release: Fix issue with tag script on osx (grafana#19557) Release: Update latest (grafana#19559) ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Oct 4, 2019
* grafana/master: (54 commits) Revert "Feature: Adds connectWithCleanup HOC (grafana#19392)" (grafana#19628) Feature: Adds connectWithCleanup HOC (grafana#19392) Panels: Progress on new singlestat / BigValue (grafana#19374) Units: fixed wrong id for Terabits/sec (grafana#19611) Docs: General improvements to docs, and a fix in oauth (grafana#19587) Docs: Replace ampersands with and (grafana#19609) Profile: Fix issue with user profile not showing more than sessions some times (grafana#19578) Azure Monitor : Query more than 10 dimensions ( Fixes grafana#17230 ) (grafana#18693) Login: Show SAML login button if SAML is enabled (grafana#19591) UI: Adds Modal component (grafana#19369) Prometheus: Fixes so results in Panel always are sorted by query order (grafana#19597) Docs: Improve guides for contributing (grafana#19575) Migration: Migrates Admin settings from angular to react (grafana#19594) Chore: Converts HelpModal from angular to react (grafana#19474) Fix typo (grafana#19571) Chore: Upgrade to Go 1.13 (grafana#19502) Explore: Move data source loader into the select (grafana#19465) Theme: fixed issue with theme always beeing modified (grafana#19517) Release: Fix issue with tag script on osx (grafana#19557) Release: Update latest (grafana#19559) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bug reproducing: In profile page (tab
Preferencein menu bar), when we navigate from dashboard to Preference, sometime we get onlySessionssection, other sections such asEdit Profile,TeamsandOrg.not found (crashing by<UserOrganizations/>).Which issue(s) this PR fixes:
Fixes #
Nothing
Special notes for your reviewer:
I see profile page use
<react-profile-wrapper>, which is a component converted from React to Angular. In<react-profile-wrapper>, component<UserOrganizations/>will be crashed if propuserisnull(because inside<UserOrganizations/>, we accessesuser.orgId).I've fixed this bug by checking whether
userwas loaded.