DataLinks: Fix url field not releasing focus #19804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
reviewed
Oct 16, 2019
| onOptionsChange: ( | ||
| options: T, | ||
| // callback can be used to run something right after update. | ||
| callback?: () => void |
There was a problem hiding this comment.
Is this necessary? I can't see any callback being passed to this prop anywhere in this PR.
There was a problem hiding this comment.
It's passed here https://github.com/grafana/grafana/pull/19804/files#diff-f715345ae09960ce639d3e8daf07aff6R56 and this is what is passed as onOptionsChange https://github.com/grafana/grafana/pull/19804/files#diff-6e9276e76a52b87735ffbbb4306fa5a8R168
dprokop
approved these changes
Oct 16, 2019
papagian
pushed a commit
that referenced
this pull request
Oct 16, 2019
(cherry picked from commit 09a5999)
papagian
pushed a commit
that referenced
this pull request
Oct 16, 2019
(cherry picked from commit 09a5999)
teodoryantcheff
pushed a commit
to teodoryantcheff/grafana
that referenced
this pull request
Dec 18, 2019
(cherry picked from commit 09a5999)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using DataLinks with gauge or single stat, the url field would not release focus so making it impossible to edit anything else afterwards.
Related somewhat to #19799