Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating: Made default template variable query editor field a textarea with automatic height #20288

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Nov 8, 2019

Changes the default query variable editor from a simple text input to a text area.

Height (rows) it automatically based on number of newlines in the query. So it starts looking the same as today with just one row height. But expands automatically as you hit enter / add new lines.

image

@torkelo torkelo added this to the 6.5.0-beta1 milestone Nov 8, 2019
@torkelo torkelo changed the title Templating: Made default template variable query editor field a textarea with dynamic automatic height Templating: Made default template variable query editor field a textarea with automatic height Nov 8, 2019
@torkelo torkelo requested a review from hugohaggmark November 11, 2019 08:56
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@torkelo torkelo merged commit dd6f5ef into master Nov 11, 2019
@torkelo torkelo deleted the template-variable-query-field-text-area branch November 11, 2019 09:04
kylebrandt pushed a commit that referenced this pull request Nov 13, 2019
…area with dynamic automatic height (#20288)

(cherry picked from commit dd6f5ef)
kylebrandt pushed a commit that referenced this pull request Nov 14, 2019
…area with dynamic automatic height (#20288)

(cherry picked from commit dd6f5ef)
@hugohaggmark
Copy link
Contributor

Fixes #15216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants