OpenTSDB: Adding lookup limit to OpenTSDB datasource settings #20647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI screenshot, again from smalik03:
|
|
We converted this config editor (the options view) to react so sadly this has updated. |
|
I can do the update to React. |
itamarst
force-pushed
the
opentsdb_lookup_limit
branch
from
6fb4fb2 to
813c353
Compare
Adding lookup to OpenTSDB datasource settings and using it in the datasource for tag value lookup and suggest
itamarst
force-pushed
the
opentsdb_lookup_limit
branch
from
813c353 to
8da1d50
Compare
|
@torkelo this has been updated to use React, although I am not a React programmer so I might've done it wrong. |
|
@torkelo and now all check pass. |
torkelo
changed the title
torkelo
approved these changes
Dec 12, 2019
ryantxu
pushed a commit
to ryantxu/grafana
that referenced
this pull request
Dec 23, 2019
…a#20647) * feat: adding lookup limit to OpenTSDB settings Adding lookup to OpenTSDB datasource settings and using it in the datasource for tag value lookup and suggest * Document the change. * feat: UI for configuring OpenTSDB lookup limit. * Apply prettier. * Fix compilation error.
johntdyer
pushed a commit
to johntdyer/grafana
that referenced
this pull request
Jan 2, 2020
…a#20647) * feat: adding lookup limit to OpenTSDB settings Adding lookup to OpenTSDB datasource settings and using it in the datasource for tag value lookup and suggest * Document the change. * feat: UI for configuring OpenTSDB lookup limit. * Apply prettier. * Fix compilation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding lookup limit to OpenTSDB datasource settings and using it in the datasource for tag value lookup and suggest. The limits were hard-coded to 1000 which made it difficult to query more metrics and tag values.
This is a rebase of #16754, authored by @smalik03, with the addition of a tiny bit of documentation.
Which issue(s) this PR fixes:
Fixes #8155