Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Skip enterprise builds for forked PRs #22851

Merged
merged 7 commits into from
Mar 17, 2020

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Mar 17, 2020

What this PR does / why we need it:
Fix builds of forked PRs by:

  • Skipping enterprise build jobs (enterprise will fail for forked PRs due to required SSH key not being shared)
  • Downloading the Grafana Build Pipeline tool from GCS, since cloning it from GitHub will fail for forked PRs (see above point for reason)

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 requested review from marefr, ryantxu, torkelo and xlson March 17, 2020 17:09
@torkelo
Copy link
Member

torkelo commented Mar 17, 2020

has CIRCLE_PR_NUMBER a value for forked PRs?

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Copy link
Contributor Author

aknuds1 commented Mar 17, 2020

Is CIRCLE_PR_NUMBER only true for for forked PRs?

@torkelo Yes.

Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Still don't understand why this is needed now when it wasn't needed before?

@aknuds1
Copy link
Contributor Author

aknuds1 commented Mar 17, 2020

@marefr Me too, brother...

@aknuds1
Copy link
Contributor Author

aknuds1 commented Mar 17, 2020

There are still some issues that need working out, i.e. end to end tests fail.

aknuds1 added 2 commits March 17, 2020 19:30
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@ryantxu
Copy link
Member

ryantxu commented Mar 17, 2020

Is CIRCLE_PR_NUMBER only true for for forked PRs?

@torkelo Yes.

Weird... I guess you are right :) But CIRCLE_PULL_REQUEST(S) exists for all PRs:

image

aknuds1 added 3 commits March 17, 2020 19:47
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 merged commit 756ad31 into grafana:master Mar 17, 2020
@aknuds1 aknuds1 deleted the bugfix/fix-circleci branch March 17, 2020 20:39
bergquist added a commit that referenced this pull request Mar 18, 2020
* master: (113 commits)
  AlertNotifications: Translate notifications IDs to UIDs in Rule builder (#19882)
  CircleCI: Don't build Storybook on PR (#22865)
  Graphite: Rollup Indicator (#22738)
  Plugins: Return jsondetails as an json object instead of raw json on datasource healthchecks. (#22859)
  Backend plugins: Exclude plugin metrics in Grafana's metrics endpoint (#22857)
  Graphite: Fixed issue with query editor and next select metric now showing after selecting metric node  (#22856)
  Webpack: Fix webpack for enterprise (#22863)
  Metrics: Storybook documented components  (#22854)
  Search: Improve tags layout , #22804 (#22830)
  Stackdriver: Fix GCE auth bug when creating new data source (#22836)
  @grafana/runtime: Add cancellation of queries to DataSourceWithBackend (#22818)
  Rich history: Test coverage (#22852)
  Chore: Support Volta in package.json (#22849)
  CircleCI: Skip enterprise builds for forked PRs (#22851)
  Toolkit: docker image for plugin CI process (#22790)
  Revert "Explore: Add test coverage for Rich history (#22722)" (#22850)
  Datasource config was not mapped for datasource healthcheck (#22848)
  upgrades plugin sdk to 0.30.0 (#22846)
  Explore: Add test coverage for Rich history (#22722)
  Rich History: UX adjustments and fixes (#22729)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants