Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Move old Switch to legacy namespace #23357

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

tskarhed
Copy link
Contributor

@tskarhed tskarhed commented Apr 6, 2020

@tskarhed tskarhed requested a review from mckn April 7, 2020 05:24
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small question regarding the legacy switch.

};

export { Switch };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we export this one both in the root and within the LegacyForms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with previous migrations I had the issue that the Enterprise build broke. I'll change the root export when using the new form styles, so there is always a Switch exported in root.

@tskarhed tskarhed merged commit 553f50e into master Apr 7, 2020
@tskarhed tskarhed deleted the forms/switch-legacy-namespace branch April 7, 2020 06:50
@tskarhed tskarhed added this to the 7.0-beta1 milestone Apr 27, 2020
@dprokop dprokop changed the title Form migrations: Switch to LegacyForms namespace Migration: Move old Switch to legacy namespace Apr 28, 2020
@ying-jeanne ying-jeanne added pr/external This PR is from external contributor and removed pr/external This PR is from external contributor labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants