-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudWatch: Add Route53 DNSQueries metric and dimension #25125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
approved these changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marefr
added
add to changelog
datasource/CloudWatch
pr/external
This PR is from external contributor
area/backend
labels
May 26, 2020
@erkolson thanks. Can you please rebase/merge with master and then we can merge this. |
marefr
changed the title
Plugins: Add Route53 DNSQueries metric
CloudWatch: Add Route53 DNSQueries metric and dimension
May 26, 2020
…na into route53-dnsqueries-metric
I think this is up to date now, hopefully it can be merged before master is updated again 😆 |
Thank you for contributing to Grafana! |
aknuds1
pushed a commit
that referenced
this pull request
Jun 30, 2020
Co-authored-by: Ilya Stoliar <52413756+ilyastoli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
datasource/CloudWatch
pr/external
This PR is from external contributor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the AWS Cloudwatch Route53
DNSQueries
metricWhich issue(s) this PR fixes:
n/a