Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break dashboard settings UI when time intervals end with trailing comma #26126

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Jul 7, 2020

Fixes #26097

Done:

  1. Time intervals input is controlled now and change is propagated on blur
  2. SettingsCtrl makes sure saved refresh intervals do not contain empty values

Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we have some other strange problems with the interval options, like
#25842

@dprokop
Copy link
Member Author

dprokop commented Jul 7, 2020

Looks good, we have some other strange problems with the interval options, like #25842

@torkelo yeah, that one is really strange and I got confused as well:D But at the same time it's a consequence of the configuration, so the question is - do we want the user-configured intervals to override the config? Currently, it's an inclusive relation - whatever is configured in the min_refresh_interval lands in the refresh picker ¯_(ツ)_/¯

I would expect and I think that whatever the user put into the refresh intervals settings should take precedence over any other settings.

@dprokop dprokop merged commit 30a682a into master Jul 8, 2020
@dprokop dprokop deleted the fix-refresh-intervals branch July 8, 2020 06:52
aocenas pushed a commit that referenced this pull request Jul 10, 2020
aocenas pushed a commit that referenced this pull request Jul 13, 2020
@aocenas aocenas modified the milestones: 7.1, 7.1-beta3 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-refresh interval trailing comma breaks Time Options
3 participants