Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units: Allow re-scaling nanoseconds up to days #26458

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

kaydelaney
Copy link
Contributor

What this PR does / why we need it:
Previously nanoseconds could only be re-scaled up to minutes. This PR allows nanoseconds to be scaled up to days.

Which issue(s) this PR fixes:
Closes #26428

@kaydelaney kaydelaney added this to the 7.2 milestone Jul 20, 2020
@kaydelaney kaydelaney requested review from peterholmberg and a team July 20, 2020 15:06
@kaydelaney kaydelaney self-assigned this Jul 20, 2020
@kaydelaney kaydelaney requested review from mckn and removed request for a team July 20, 2020 15:06
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kaydelaney kaydelaney merged commit 3c72b2f into master Jul 21, 2020
@kaydelaney kaydelaney deleted the issue-26428 branch July 21, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units: nanosecond unit to scale to hours
3 participants