Backend: Fix IPv6 address parsing erroneous #28585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taciomcosta
requested review from
wbrowne and
kylebrandt
and removed request for
a team
|
|
|
Try merging Grafana master into your branch, that might resolve the CI failure. |
|
Having a look. |
aknuds1
requested changes
Oct 28, 2020
taciomcosta
force-pushed
the
issue/28203
branch
from
01f84bc to
1bd58f4
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
…ddress-parsing Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
…ddress-parsing Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
Thanks for the PR, would you mind merging the changes I made in this branch? We've determined that this is the approach we want to go with. |
|
Thanks! |
torkelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It changes IPv6 parsing to accept ips that are not surround by brackets, it is, that don't include ports.
Example:
2001:608:0:a00::102d becomes acceptable
Which issue(s) this PR fixes:
28203 - IPv6 adress parsing errornous
Fixes #28203
Special notes for your reviewer: