Table: Fixes issues with phantom extra 0 for zero values #29165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
added
area/panel/table
backport
torkelo
approved these changes
Nov 17, 2020
hugohaggmark
approved these changes
Nov 18, 2020
| @@ -49,7 +49,7 @@ export const DefaultCell: FC<TableCellProps> = props => { | |||
| {value} | |||
| </a> | |||
| )} | |||
| {showFilters && cell.value && <FilterActions {...props} />} | |||
| {showFilters && cell.value !== undefined && <FilterActions {...props} />} | |||
There was a problem hiding this comment.
nit: I read somewhere about React best practices that we should try to use ternaries instead.
Suggested change
| {showFilters && cell.value !== undefined && <FilterActions {...props} />} | |
| {showFilters && cell.value ? <FilterActions {...props} /> : null} |
There was a problem hiding this comment.
It will display 'false' as text if the condition is false, should be:
{showFilters && cell.value !== undefined ? <FilterActions {...props} /> : null}
grafanabot
pushed a commit
that referenced
this pull request
Nov 18, 2020
(cherry picked from commit f28ba27)
dprokop
added a commit
that referenced
this pull request
Nov 18, 2020
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
torkelo
changed the title
|
This was a really poor title for changelog, explains not the user impact of the bugfix (phantom zeros for zero values). Need to remember PR titles matter :) |
torkelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29108