-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Support pre-installed plugins from other sources in custom Dockerfiles #31234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, the technical changes make sense, but I'd have to hear with others to figure out if we want this. I think also documentation would have to be updated to reflect this support?
@sgnsys3 could you please open a feature request describing the use case more detailed and why you cannot customize this in your custom built image and why it should be included in our custom image. Then reference the created issue in the PR description. Thanks |
@marefr I have created and reference issue in this PR. This is correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion in the issue this looks good. But the ubuntu.Dockerfile needs update as well.
@marefr I updated ubuntu.Dockerfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a bit fast there.
- Please merge with master to resolve CI build problems.
- Please update this section in the documentation to denote installing plugins from other sources is supported. For reference, here's the markdown file that needs update.
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing to Grafana! |
Shouldn't need backport since documentation refers to this repository for building custom Docker image and the master branch is the default. |
…ockerfiles (grafana#31234) Update custom Dockerfiles to support pre-installing plugins from other sources. Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
What this PR does / why we need it:
Refer to this document: https://grafana.com/docs/grafana/latest/installation/docker/#build-and-run-a-docker-image-with-pre-installed-plugins
Installing plugins from URL is not supported when building Docker image with pre-installed plugins.
Which issue(s) this PR fixes:
Add install plugins from URL script when building Docker image with pre-installed plugins.
Fixes: #31302