-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login: Fixes Unauthorized message showing when on login page or snapshot page #35311
Conversation
if (contextSrv.user.orgRole !== '') { | ||
registerEchoBackend(new PerformanceBackend({})); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this fixes the issue @torkelo. The backend still gets registered on the login page and the metrics are sent, yet I don't get why it doesn't throw the Unauthorized.. error now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, and the orgRole for myself on the login page is Viewer
. Is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprokop with anonymous access disabled I do not get this backend registered nor any metrics sent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprokop do you have anonymous access enabled? if not then that is strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, its the anonym access.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-35311-to-v7.5.x origin/v7.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x ce513e4637e2f8fbe56bb8a8c9077bf57a798ca2
# Push it to GitHub
git push --set-upstream origin backport-35311-to-v7.5.x
git switch main
# Remove the local backport branch
git branch -D backport-35311-to-v7.5.x Then, create a pull request where the |
Fixes #33764