Geomap: add initial openlayers alpha panel #36188
Conversation
| const category = getOptionsPaneCategory(pluginOption.category); | ||
| const Editor = pluginOption.editor; | ||
|
|
||
| // TODO? can some options recursivly call: fillOptionsPaneItems? |
There was a problem hiding this comment.
@torkelo -- I refactored so LayerEditor uses the same function. We could explore getting nested properties from the plugin. For example maybe:
pluginOption.getNestedOptions(context.options, context.data) => PanelOptionsEditorItem[]
and then we could recursively call fillOptionsPaneItems?
I think it could work -- but should be pursued in its own issue
ryantxu
requested review from
torkelo
and removed request for
pkolyvas,
a team,
zserge,
idafurjes,
sunker,
vickyyyyyyy,
oddlittlebird,
achatterjee-grafana,
osg-grafana,
Elfo404 and
marcusolsson
| name?: string; // configured display name | ||
|
|
||
| // Layer transparency | ||
| transparency?: number; |
There was a problem hiding this comment.
We could leave this out now and add it when it is used -- the point is to make sure we have a level of options that apply to all layers regardless of type. Other values will include:
https://openlayers.org/en/latest/apidoc/module-ol_layer_Base-BaseLayer.html
| constructor(props: Props) { | ||
| super(props); | ||
| } |
| } | ||
|
|
||
| export class DebugOverlay extends PureComponent<Props, State> { | ||
| style = getStyles(config.theme); |
There was a problem hiding this comment.
We keep styles in the render function- it's memoized so is not a perf issue
| export const LayerEditor: FC<LayerEditorProps> = ({ config, onChange, data, filter }) => { | ||
| // all basemaps | ||
| const layerTypes = useMemo(() => { | ||
| return geomapLayerRegistry.selectOptions( |
There was a problem hiding this comment.
I am thinking along the same lines as @torkel. I would expect either using showIf for given layer editor rendering, or passing down the original builder into custom editor so that the extended options could become subject of search too :) I think the problem will be with changing editors, as we do not re-initialize the builder every time and we would have to have a way to remove the options when the custom editor unmounts.
| <Select | ||
| options={views.options} | ||
| value={views.current} | ||
| onChange={(v) => { | ||
| onChange({ | ||
| id: v.value!, | ||
| }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Can this editor be created with just addSelect instead? And then the coordinates editor would become a conditional option(s)
There was a problem hiding this comment.
Maybe -- but I was hoping for something a little more fancy that knows what the current map view is and can explicitly get them in sync.
| context, | ||
| }) => { | ||
| // TODO: | ||
| // Somehow use context to get the current map and listen to zoom changes |
There was a problem hiding this comment.
Why not hooking up the panel.onPanelOptionsChange callback to zoom interaction directly in the panel implementation? I don't think options pane should ever reference the implemetation detail of the panel
There was a problem hiding this comment.
because it should be explicitly set from the editor -- In the editor I want two things:
- show your current zoom/view
- press a button to use it
We can (and likely should) send the current view over the EventBus -- this is fine for getting changes, but you can not get the current value :(
| id: 'view.zoom', | ||
| path: 'view.zoom', | ||
| name: 'Initial zoom', | ||
| editor: MapZoomEditor, |
See also: #36585
This is an alternative approach from:
#35915
Rather than using leaflet, it is based on open layers. Open layers is way more feature packed, but does require thinking about projections.
TODO: