Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres/MySQL/MSSQL: Change time field to "Time" for time series queries #36720

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

marefr
Copy link
Member

@marefr marefr commented Jul 13, 2021

What this PR does / why we need it:
Name of time field changed in v8 for time series queries from Time to the name of the selected time column, i.e. time or time_sec. These changes should make sure that the name of time field is always returned as Time for time series queries.

Which issue(s) this PR fixes:
Fixes #36059

Special notes for your reviewer:

@marefr marefr added this to the 8.0.6 milestone Jul 13, 2021
@marefr marefr requested a review from a team as a code owner July 13, 2021 16:31
@marefr marefr requested review from idafurjes, ying-jeanne and torkelo and removed request for a team July 13, 2021 16:31
@marefr marefr added old backport v8.0.x Mark PR for automatic backport to v8.0.x add to changelog labels Jul 13, 2021
Copy link
Contributor

@idafurjes idafurjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idafurjes idafurjes closed this Jul 13, 2021
@idafurjes idafurjes reopened this Jul 13, 2021
pkg/tsdb/mysql/mysql_test.go Outdated Show resolved Hide resolved
pkg/tsdb/mysql/mysql_test.go Outdated Show resolved Hide resolved
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
@marefr marefr merged commit 10c892f into main Jul 14, 2021
@marefr marefr deleted the 36059_fix branch July 14, 2021 09:29
grafanabot pushed a commit that referenced this pull request Jul 14, 2021
… time series queries (#36720)

Name of time field changed in v8 for time series queries from Time to the name of the selected
time column, i.e. time or time_sec. These changes should make sure that the name of time field
is always returned as Time for time series queries.

Fixes #36059

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
(cherry picked from commit 10c892f)
kaydelaney pushed a commit that referenced this pull request Jul 14, 2021
… time series queries (#36720) (#36746)

Name of time field changed in v8 for time series queries from Time to the name of the selected
time column, i.e. time or time_sec. These changes should make sure that the name of time field
is always returned as Time for time series queries.

Fixes #36059

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
(cherry picked from commit 10c892f)

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
@kaydelaney kaydelaney changed the title Postgres/MySQL/MSSQL: Fix name of time field should be named Time for time series queries Postgres/MySQL/MSSQL: Change time field to "Time" for time series queries Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: Name of time field changed in v8
5 participants