Graphite: Deprecate browser access mode. #38783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifrost
requested review from
osg-grafana and
KMiller-Grafana
and removed request for
a team
grafanabot
added
area/frontend
type/docs
Elfo404
reviewed
Sep 1, 2021
Elfo404
approved these changes
Sep 1, 2021
achatterjee-grafana
approved these changes
Sep 1, 2021
achatterjee-grafana
added
the
old backport v8.1.x
|
Doc needs to be backported to 8.1, ideally to 8.0 as well. |
achatterjee-grafana
changed the title
|
This PR also fixes #38601. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-38783-to-v8.0.x origin/v8.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x f9413906313c5578a1dce044150555a57bb56ddd
# Push it to GitHub
git push --set-upstream origin backport-38783-to-v8.0.x
git switch main
# Remove the local backport branch
git branch -D backport-38783-to-v8.0.xThen, create a pull request where the |
grafanabot
pushed a commit
that referenced
this pull request
Sep 2, 2021
* Deprecate browser access mode for Graphite * Update docs * Update copy (cherry picked from commit f941390)
ifrost
added a commit
that referenced
this pull request
Sep 2, 2021
achatterjee-grafana
changed the title
stevepostill
pushed a commit
to Reveal-International/grafana
that referenced
this pull request
Nov 3, 2021
…-github to revdev * commit '0d046c46b480ffc5fd602142a2b0e5dfc765b620': (63 commits) "Release: Updated versions in package to 8.1.3" (grafana#38965) Change grabpl version to 2.3.4 (grafana#38967) PieChart: Display "No data" when there is no data (grafana#38808) (grafana#38960) track signature files + add warn log (grafana#38938) (grafana#38958) Docs: Clarify delta value (grafana#38824) (grafana#38916) Postgres/MySQL/MSSQL: Fix region annotations not displayed correctly (grafana#38936) (grafana#38953) uPlot: Fix default value for plot legend visibility (grafana#36660) (grafana#38930) Prometheus: Fix validate selector in metrics browser (grafana#38921) (grafana#38926) Dashboard: Forces panel re-render when exiting panel edit (grafana#38913) (grafana#38919) [v8.1.x] Dashboard: Fix UIDs are not preserved when importing/creating dashboards thru importing .json file (grafana#38892) OAuth: add docs for disableAutoLogin param (grafana#38752) (grafana#38896) LibraryPanels: Prevents duplicate repeated panels from being created (grafana#38804) (grafana#38863) Adding missing information, more than just the manual backport. (grafana#38837) Elasticsearch: Prevent pipeline aggregations to show up in terms order by options (grafana#38448) (grafana#38830) Build: Upgrade grabpl to 2.4.2 (grafana#38820) (grafana#38828) Alerting: Fix alert flapping in the internal alertmanager (grafana#38648) (grafana#38829) [v8.1.x] Chore: Update to alpine:3.14.2 (grafana#38821) Update Dockerfile (grafana#38785) (grafana#38815) Deprecate browser access mode for the Graphite data source. (grafana#38783) (grafana#38809) Live: prepend orgId when publishing from HTTP (grafana#38775) (grafana#38793) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Browser (direct) access mode switcher was removed from Graphite configuration page in Grafana 6.6.0 (#20444). This option was just not added when configuration page was migrated to React and
DataSourceHttpSettingscomponent which requires explicitly showing it by passingshowAccessOptions={true}. (Note that a similar thing happened with Prometheus in #20248 but it was fixed in #21833). Since then the only way to set browser access mode for Graphite is to provision the data source withaccess: directsettings.We plan to remove browser access mode for some data sources and there's no guarantee we will keep it for Graphite so I just added a deprecation warning (similar to a warning that was added to Elastic in #29649) when it's already set:
Which issue(s) this PR fixes:
Fixes #38601
Special notes for your reviewer:
For the reference, this is how the config page changed between 6.5.0 and 6.6.0: