Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimePicker: Add fiscal years and search to time picker #39073

Merged
merged 29 commits into from
Sep 30, 2021
Merged

TimePicker: Add fiscal years and search to time picker #39073

merged 29 commits into from
Sep 30, 2021

Conversation

oscarkilhed
Copy link
Contributor

@oscarkilhed oscarkilhed commented Sep 10, 2021 •
edited
Loading

What this PR does / why we need it:

This adds fiscal year rounding to the time picker. It will now be possible to round to the start/end of a fiscal year or quarter using now/fy and now/fQ. When adding the fiscal time ranges the list got pretty long, so this also introduces a search function for the time picker.

Closes: #39052

dprokop
dprokop reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looking good so far! Left few nits/comments

packages/grafana-data/src/datetime/datemath.ts Outdated Show resolved Hide resolved
packages/grafana-data/src/datetime/datemath.ts Outdated Show resolved Hide resolved
public/app/core/components/PageActionBar/PageActionBar.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/DateTimePickers/TimeRangePicker/TimePickerContent.tsx Outdated Show resolved Hide resolved
@dprokop dprokop added this to the 8.2.0 milestone Sep 16, 2021
@oscarkilhed
Fix tests
72c2ea5
@oscarkilhed
Remove unused import
0025bcf
@oscarkilhed
UX fixes on time picker
e7fa25e 
auto focus on search field
clear don't close the time picker
clear sets the focus on input field
@oscarkilhed
Expose FilterInput and change auto added imports
685b283
@softagram
Copy link

softagram bot commented Sep 17, 2021

General status Direct impact Duplicate code Rule violations
🎉 Looking good 34 files ✔️ Add your rules

See the full Softagram report

@oscarkilhed oscarkilhed changed the title Add search to time picker Add fiscal years and search to time picker Sep 28, 2021
@oscarkilhed oscarkilhed requested review from pkolyvas and a team as code owners September 29, 2021 12:12
@oscarkilhed oscarkilhed requested review from osg-grafana and Eve832 and removed request for a team September 29, 2021 12:12
@torkelo
Copy link
Member

torkelo commented Sep 29, 2021

not related to this PR but noticed that the FilterInput blocks of the placeholder text. I assume it's for the clear action, but that should not be needed when there is nothing in the input :)

Screenshot from 2021-09-29 14-26-35
t

@torkelo
Copy link
Member

torkelo commented Sep 29, 2021

I cannot use the keyboard to select the time ranges, I think this is pretty essential to make a search like this really useful and quick. Having a search input that support arrow up / down & enter to select seems like something that would be nice to have as a generic component that can be used for different list types :)

@oscarkilhed
Copy link
Contributor Author

oscarkilhed commented Sep 29, 2021 •
edited
Loading

@torkelo

I cannot use the keyboard to select the time ranges, I think this is pretty essential to make a search like this really useful and quick. Having a search input that support arrow up / down & enter to select seems like something that would be nice to have as a generic component that can be used for different list types :)

I agree, I planned on adding that if we have time before the next release.

@grafanabot grafanabot added the type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project label Sep 29, 2021
@oscarkilhed
Copy link
Contributor Author

not related to this PR but noticed that the FilterInput blocks of the placeholder text. I assume it's for the clear action, but that should not be needed when there is nothing in the input :)

Screenshot from 2021-09-29 14-26-35 t

fixed in e5b9d6c

@torkelo
Copy link
Member

torkelo commented Sep 29, 2021

Timepicker bug (not related to this), #39806

@torkelo
Copy link
Member

torkelo commented Sep 29, 2021

fixed in e5b9d6c

great!

@oscarkilhed oscarkilhed added add to changelog and removed type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project labels Sep 30, 2021
@oscarkilhed oscarkilhed merged commit 738d5e4 into main Sep 30, 2021
@oscarkilhed oscarkilhed deleted the oscark/time-picker-fiscal branch September 30, 2021 07:40
grafanabot pushed a commit that referenced this pull request Sep 30, 2021
@oscarkilhed @grafanabot
Add fiscal years and search to time picker (#39073)
b6336f2 
* Add search to time picker

* implement fiscal datemath

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit 738d5e4)
@grafanabot grafanabot mentioned this pull request Sep 30, 2021
Merged
oscarkilhed added a commit that referenced this pull request Sep 30, 2021
@grafanabot @oscarkilhed
Add fiscal years and search to time picker (#39073) (#39828)
229c45c 
* Add search to time picker

* implement fiscal datemath

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit 738d5e4)

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
@oscarkilhed oscarkilhed mentioned this pull request Sep 30, 2021
Merged
@ivanahuckova ivanahuckova changed the title Add fiscal years and search to time picker TimePicker: Add fiscal years and search to time picker Sep 30, 2021
@tomahkvt tomahkvt mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugohaggmark hugohaggmark hugohaggmark left review comments

@dprokop dprokop dprokop approved these changes

@torkelo torkelo Awaiting requested review from torkelo

@axelavargas axelavargas Awaiting requested review from axelavargas

@davkal davkal Awaiting requested review from davkal

Assignees
No one assigned
Labels
add to changelog area/dashboard/timerange area/explore area/frontend old backport v8.2.x Mark PR for automatic backport to v8.2.x
Projects
None yet
Milestone
8.2.0-beta2
Development

Successfully merging this pull request may close these issues.

Dashboard Time Picker — Months & Quarters Time Ranges
6 participants
@oscarkilhed @dprokop @amy-super @torkelo @hugohaggmark @grafanabot