Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Add error details when json upload fails #41803

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Nov 17, 2021

Just add console log and append the error to the message for quicker debugging.

@aocenas aocenas requested review from a team, ifrost, connorlindsey and ivanahuckova and removed request for a team and ifrost November 17, 2021 13:40
@aocenas aocenas added this to the 8.3.0 milestone Nov 17, 2021
Copy link
Contributor

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add this to Zipkin and Jaeger file upload as I think they have the exact same code

@aocenas aocenas merged commit 5cd4cde into main Nov 18, 2021
@aocenas aocenas deleted the aocenas/tempo/add-json-upload-error branch November 18, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants