CloudMonitoring: Fixes broken variable queries that use group bys #43914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
type/bug
datasource/GoogleCloudMonitoring
add to changelog
backport v8.3.x
sunker
requested review from
a team,
fridgepoet,
yaelleC,
sarahzinger and
andresmgot
and removed request for
a team
andresmgot
approved these changes
Jan 12, 2022
| const labels = await this.datasource.getLabels(selectedMetricType, refId, projectName, [labelKey]); | ||
| const labels = await this.datasource.getLabels(selectedMetricType, refId, projectName, { | ||
| groupBys: [labelKey], | ||
| crossSeriesReducer: 'REDUCE_MEAN', |
There was a problem hiding this comment.
a comment (or better a test) to explain why this is set would be helpful
andresmgot
added
backport v8.3.x
|
merging this to be included in 8.3.4 |
andresmgot
pushed a commit
that referenced
this pull request
Jan 17, 2022
xlson
added a commit
to joanlopez/grafana
that referenced
this pull request
Jan 17, 2022
* origin/main: Split prepare-release (grafana#44124) Fix issue link (grafana#42891) Release: remove bump from prepare release action (grafana#44111) Access control: Team role picker (grafana#43418) Plugins: Add notices to docs to prevent NPX commands from hanging (grafana#44043) Azure Monitor: Improved error messages for variable queries (grafana#43213) CloudMonitoring: Fixes broken variable queries that use group bys (grafana#43914) Elastic: Allow using long/int as date field for alerts (grafana#44027) Prometheus: Fix interpolation of $__rate_interval variable (grafana#44035) Alerting: show deleted datasource (grafana#43891) Dashboard save interaction evt (grafana#43304) Chore: reduces circular dependencies for variables/utils.ts (grafana#44087) Chore(CodeQL): Add noopener noreferrer to external links in email templates (grafana#44092) Export: Fix error being thrown when exporting dashboards using query variables that reference the default datasource (grafana#44034) fix delete plugin dashboard (grafana#44055) Access Control: Allow signed in users access to GET data sources endpoints (grafana#43338) small fix 🙏 (grafana#44089) Update dependency marked to v4.0.10 [SECURITY] (grafana#44078) Remove Macaron ParamsInt64 function from code base (grafana#43810)
ryantxu
pushed a commit
that referenced
this pull request
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After a recent API change, cloud monitoring ignores the group by in case the crossSeriesReducer is set to REDUCE_NONE. This caused issues in the CloudMonitoring plugin when loading labels that were used in variables queries and in queries that return labels that would be used in the filter section. This PR ensures a crossSeriesReducer other than REDUCE_NONE is always specified in case a group by was provided.
Which issue(s) this PR fixes:
Fixes #43504