Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger: Update operations dropdown #49329

Merged
merged 3 commits into from
May 22, 2022
Merged

Conversation

joey-grafana
Copy link
Contributor

What this PR does / why we need it:

Updates Jaeger operations dropdown list based on the selected service.

Which issue(s) this PR fixes:

Fixes #48965

How to test:

  1. Select item in services dropdown
  2. Select operations menu and observe available options
  3. Change selected item in services dropdown
  4. Selection operations menu and observe available options have changed

Copy link
Contributor

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to do this for Tempo as well since it simplifies the code a bit

@joey-grafana
Copy link
Contributor Author

LGTM. Would be nice to do this for Tempo as well since it simplifies the code a bit

Hell yeah! Decided to get this one done first!

@joey-grafana joey-grafana merged commit f06d916 into main May 22, 2022
@joey-grafana joey-grafana deleted the joey/jaeger_ops_dropdown branch May 22, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger datasource: operations dropdown not getting updates with service change
3 participants