Alerting: Fix alert list panel showing firing alerts with no instances #50069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
area/alerting
gillesdemey
commented
Jun 2, 2022
| @@ -122,15 +122,15 @@ function filterRules(props: PanelProps<UnifiedAlertListOptions>, rules: PromRule | |||
| name.toLocaleLowerCase().includes(replacedName.toLocaleLowerCase()) | |||
| ); | |||
| } | |||
| if (Object.values(options.stateFilter).some((value) => value)) { | |||
There was a problem hiding this comment.
This was the root of the problem, we only filtered alerts when any of the state filters were true, meaning that if no states were selected it would show firing alerts with 0 instances (they instances are filtered in GroupedModeView)
konrad147
approved these changes
Jun 2, 2022
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/20815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug where the alert list panel would show firing alerts with no instances.
Additionally it clarifies that no alerts are shown that match the current set of filters and indicates how many instances are not being shown (because they are hidden by at least one of the alert state filters).
Special notes for your reviewer: