Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Fix scrollbar being hidden by pagination #51501

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Table: Fix scrollbar being hidden by pagination #51501

merged 3 commits into from
Jul 8, 2022

Conversation

zoltanbedi
Copy link
Member

What this PR does / why we need it:
This PR fixes a couple of issues with the pagination.

  1. Centering of the pagination element.
Before After
Screenshot 2022-06-28 at 15 40 49 Screenshot 2022-06-28 at 15 40 42
  1. Scrolling element is hidden behind pagination.
Before After
Screenshot 2022-06-28 at 15 55 38 Screenshot 2022-06-28 at 15 55 10
  1. Frame dropdown hides pagination.
Before After
Screenshot 2022-06-28 at 15 59 47 Screenshot 2022-06-28 at 15 59 38

Which issue(s) this PR fixes:

Fixes #50394

@zoltanbedi zoltanbedi added this to the 9.1.0 milestone Jun 28, 2022
@zoltanbedi zoltanbedi requested a review from a team June 28, 2022 14:04
@zoltanbedi zoltanbedi self-assigned this Jun 28, 2022
@zoltanbedi zoltanbedi requested review from oscarkilhed and davkal and removed request for a team June 28, 2022 14:04
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24354

@zoltanbedi zoltanbedi modified the milestones: 9.1.0, 9.0.3 Jun 28, 2022
@zoltanbedi zoltanbedi added backport v9.0.x and removed no-backport Skip backport of PR labels Jun 28, 2022
@zoltanbedi zoltanbedi requested review from dprokop and removed request for davkal June 29, 2022 07:29
dprokop
dprokop approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! :)

@dprokop dprokop enabled auto-merge (squash) July 8, 2022 10:22
@dprokop dprokop changed the title Table: Fix scrollbar is hidden by pagination Table: Fix scrollbar being hidden by pagination Jul 8, 2022
@dprokop dprokop merged commit 506e63f into main Jul 8, 2022
@dprokop dprokop deleted the zoltan/pagination-fix branch July 8, 2022 10:28
@grafanabot grafanabot mentioned this pull request Jul 8, 2022
Merged
grafanabot pushed a commit that referenced this pull request Jul 8, 2022
@zoltanbedi @grafanabot
Table: Fix scrollbar is hidden by pagination (#51501)
17fd556 
* Table: Pagination fix centering

* Table: Fix scrollbar is hidden by pagination

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit 506e63f)
zoltanbedi added a commit that referenced this pull request Jul 11, 2022
@grafanabot @zoltanbedi
Table: Fix scrollbar is hidden by pagination (#51501) (#51960)
36b06b9 
* Table: Pagination fix centering

* Table: Fix scrollbar is hidden by pagination

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit 506e63f)

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
@zoltanbedi zoltanbedi mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop dprokop approved these changes

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

Assignees

@zoltanbedi zoltanbedi

Labels
add to changelog area/frontend area/panel/table backport v9.0.x enterprise-ok type/bug
Projects
None yet
Milestone
9.0.3
Development

Successfully merging this pull request may close these issues.

Enabling pagination in a table panel makes horizontal scrollbar disappear
3 participants
@zoltanbedi @grafanabot @dprokop