PublicDashboards: Configuration modal redesign #63211
Conversation
juanicabanas
requested review from
a team,
axelavargas and
kaydelaney
and removed request for
a team
juanicabanas
requested review from
ashharrison90,
yaelleC,
andresmgot,
oscarkilhed and
zoltanbedi
and removed request for
a team
|
When I change the time range of the whole dashboard to something other than 6 hours, and go into sharing publicly, the sharing option is still on "Last 6 hours".
|
| e2e().wait('@update'); | ||
|
|
||
| // Url should be hidden | ||
| e2e.pages.ShareDashboardModal.PublicDashboard.CopyUrlInput().should('not.exist'); | ||
| e2e.pages.ShareDashboardModal.PublicDashboard.CopyUrlInput().should('be.disabled'); | ||
| e2e.pages.ShareDashboardModal.PublicDashboard.CopyUrlButton().should('be.disabled'); |
that's because you didn't save the current time range as dashboard default. Once you do it, the change will be shown |
There was a problem hiding this comment.
Looks good!
Extremely small nitpick, but I think some slight adjustments could be made to make everything perfectly center-aligned:
Before:
After (Notice the info icon):
If you'd like I could push the changes required for this (or if you think it looks better as it is now, that's totally fine too!)
sure! make the change yourself 💪🏽 thanks for the detail, looks quite better |
|
@kaydelaney do you wanna make those changes? |
|
@juanicabanas Yep! Will do it now |
|
@grafana/dataviz-squad could you take a look at Checkbox modifications? thanks! |
|
LGTM! |
Configuration modal redesign --------- Co-authored-by: kay delaney <kay@grafana.com>
What is this feature?
Redesign for configuration modal
Which issue(s) does this PR fix?:
Fixes #4682
Special notes for your reviewer:
Before
pubdash-old-design.mov
After
pubdash-new-design.mov