PublicDashboards: Query collapsed panels inside rows #64779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evictorero
added
add to changelog
area/public-dashboards
backport v9.4.x
evictorero
requested review from
axelavargas,
polibb and
juanicabanas
and removed request for
a team
|
Hello @evictorero!
Please, if the current pull request addresses a bug fix, label it with the |
juanicabanas
approved these changes
Mar 15, 2023
grafanabot
pushed a commit
that referenced
this pull request
Mar 15, 2023
(cherry picked from commit 3f5acf3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Load panel queries inside collapsed rows.
Which issue(s) does this PR fix?:
Fixes #58702
Special notes for your reviewer:
When a public dashboard loads queries from the dashboard model it ignores those panels inside a panel of
type=rowand collapsed rows.Added a recursive call to load all panels inside collapsed rows so when a user wants to unfold the row, the panel it's found and the query request returns the data.