[grafana] fix cve-2021-25742 #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zanac1986 <zanhsieh@protonmail.com>
zanac1986
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
Signed-off-by: zanac1986 <zanhsieh@protonmail.com>
zanhsieh
approved these changes
Jun 11, 2022
|
Hello, This configuration is only valid on the ingress-nginx configmap, but you seem to have applied it to the grafana configmap. Is there another meaning of this annotation in grafana-land? Otherwise, I'm pretty sure you can't "fix" this here. I assume you got here from this linter but this linter is wrong. It only applies to the ingress-nginx configmap - not all configmaps in the cluster (that would be a K8s vulnerability, not an ingress-nginx one). Suggest to revert. I will open an issue too. Thanks for all the hard work maintaining! |
This was referenced Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zanac1986 zanhsieh@protonmail.com