Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] fix helm warning: cannot overwrite table with non table #2484

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

JeffreyVdb
Copy link
Contributor

The affinity value is expected to be passed as a string. The default values for querier and compactor were empty maps. This meant that helm would complain with the following message:

warning: cannot overwrite table with non table ...

which is basically telling the user that the type of the value in the values.yaml file is an empty map, but the value you're overriding it with is a string.

This commit fixes that issue by using the default affinity that is set for all other components (hard node and soft zone anti affinity).

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

The affinity value is expected to be passed as a string. The default
values for querier and compactor were empty maps. This meant that helm
would complain with the following message:

```
warning: cannot overwrite table with non table ...
```

which is basically telling the user that the type of the value in the
values.yaml file is an empty map, but the value you're overriding it
with is a string.

This commit fixes that issue by using the default affinity that is set
for all other components (hard node and soft zone anti affinity).

Signed-off-by: Jeffrey Vandenborne <jeffrey@vandenborne.co>
@JeffreyVdb JeffreyVdb force-pushed the default-affinity-values branch from b2492bd to 62d86eb Compare June 30, 2023 14:16
@zanhsieh zanhsieh changed the title fix helm warning: cannot overwrite table with non table [loki-distributed] fix helm warning: cannot overwrite table with non table Jul 24, 2023
@JeffreyVdb
Copy link
Contributor Author

@zanhsieh Is there anything I can do to push this one forward?

Signed-off-by: MH <zanhsieh@gmail.com>
@zanhsieh zanhsieh merged commit 2548984 into grafana:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants