-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[promtail] service-extra: custom labels not working #3220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @camrossi , could you please bump the chart version to 6.16.4
at charts/promtail/Chart.yaml to fix CI lint test.
Signed-off-by: camillo.rossi@gmail.com <camrossi@cisco.com>
Signed-off-by: camillo.rossi@gmail.com <camrossi@cisco.com>
camrossi
requested review from
mapno,
swartz-k,
BitProcessor,
faustodavid,
jkroepke,
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
July 14, 2024 22:15
Signed-off-by: camillo.rossi@gmail.com <camrossi@cisco.com>
Signed-off-by: MH <zanhsieh@gmail.com> Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Jul 15, 2024
Sheikh-Abubaker
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jul 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [promtail](https://grafana.com/loki) ([source](https://github.com/grafana/helm-charts)) | patch | `6.16.3` -> `6.16.4` | --- ### Release Notes <details> <summary>grafana/helm-charts (promtail)</summary> ### [`v6.16.4`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.4) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.3...promtail-6.16.4) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] service-extra: custom labels not working by [@​camrossi](https://github.com/camrossi) in [grafana/helm-charts#3220 #### New Contributors - [@​camrossi](https://github.com/camrossi) made their first contribution in [grafana/helm-charts#3220 **Full Changelog**: grafana/helm-charts@oncall-1.8.4...promtail-6.16.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
kodiakhq bot
pushed a commit
to cloudquery/helm-charts
that referenced
this pull request
Aug 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [promtail](https://grafana.com/loki) ([source](https://github.com/grafana/helm-charts)) | patch | `6.16.2` -> `6.16.4` | --- ### Release Notes <details> <summary>grafana/helm-charts (promtail)</summary> ### [`v6.16.4`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.4) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.3...promtail-6.16.4) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] service-extra: custom labels not working by [@​camrossi](https://github.com/camrossi) in [grafana/helm-charts#3220 #### New Contributors - [@​camrossi](https://github.com/camrossi) made their first contribution in [grafana/helm-charts#3220 **Full Changelog**: grafana/helm-charts@oncall-1.8.4...promtail-6.16.4 ### [`v6.16.3`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.3) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.2...promtail-6.16.3) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] prefer image.tag for app.kubernetes.io/version by [@​yurrriq](https://github.com/yurrriq) in [grafana/helm-charts#3200 #### New Contributors - [@​yurrriq](https://github.com/yurrriq) made their first contribution in [grafana/helm-charts#3200 **Full Changelog**: grafana/helm-charts@grafana-8.3.1...promtail-6.16.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
lambchop4prez
added a commit
to lambchop4prez/network
that referenced
this pull request
Aug 11, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [promtail](https://grafana.com/loki) ([source](https://github.com/grafana/helm-charts)) | minor | `6.15.5` -> `6.16.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grafana/helm-charts (promtail)</summary> ### [`v6.16.4`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.4) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.3...promtail-6.16.4) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] service-extra: custom labels not working by [@​camrossi](https://github.com/camrossi) in [grafana/helm-charts#3220 #### New Contributors - [@​camrossi](https://github.com/camrossi) made their first contribution in [grafana/helm-charts#3220 **Full Changelog**: grafana/helm-charts@oncall-1.8.4...promtail-6.16.4 ### [`v6.16.3`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.3) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.2...promtail-6.16.3) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] prefer image.tag for app.kubernetes.io/version by [@​yurrriq](https://github.com/yurrriq) in [grafana/helm-charts#3200 #### New Contributors - [@​yurrriq](https://github.com/yurrriq) made their first contribution in [grafana/helm-charts#3200 **Full Changelog**: grafana/helm-charts@grafana-8.3.1...promtail-6.16.3 ### [`v6.16.2`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.2) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.1...promtail-6.16.2) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] Bugfix deployment.strategy in values.yaml by [@​Sheikh-Abubaker](https://github.com/Sheikh-Abubaker) in [grafana/helm-charts#2932 **Full Changelog**: grafana/helm-charts@tempo-distributed-1.12.0...promtail-6.16.2 ### [`v6.16.1`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.1) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.16.0...promtail-6.16.1) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] Update service template to fix broken promtail. by [@​Sheikh-Abubaker](https://github.com/Sheikh-Abubaker) in [grafana/helm-charts#3164 **Full Changelog**: grafana/helm-charts@helm-loki-6.6.4...promtail-6.16.1 ### [`v6.16.0`](https://github.com/grafana/helm-charts/releases/tag/promtail-6.16.0) [Compare Source](https://github.com/grafana/helm-charts/compare/promtail-6.15.5...promtail-6.16.0) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] update to 3.0.0 by [@​mjnagel](https://github.com/mjnagel) in [grafana/helm-charts#3083 #### New Contributors - [@​mjnagel](https://github.com/mjnagel) made their first contribution in [grafana/helm-charts#3083 **Full Changelog**: grafana/helm-charts@grafana-agent-operator-0.4.0...promtail-6.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/lambchop4prez/network). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3219