Add OCI registry support for all Helm charts #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
|
|
|
Thank you for the PR. The changes look very similar to an earlier PR #3115 (which got slipped from the final reviews). Could you help testing it? |
Signed-off-by: Oliver Domokos <domolitom@gmail.com>
domolitom
force-pushed
the
feat/update-release-to-oci
branch
from
2ac41cd
to
e3cb277
Compare
narqo
approved these changes
Oct 24, 2024
zalegrala
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Helm charts, such as Loki, are not being pushed to an OCI registry because OCI support is missing in the
update-helm-repo.yamlworkflow, which is used for external releases.Solution: This PR introduces a step that ensures Helm charts are also pushed to the GitHub Container Registry (GHCR) as part of the release process, providing OCI support for charts that were previously excluded.