-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k6 version in tests #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to the tasks list for k6 releases? 🤔 cc/ @grafana/k6-core
@joanlopez Yes, but if it is possible we should link the latest version so we don't have to update it at all. https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases#linking-to-the-latest-release |
Even better, right! 🚀 |
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
I kind of prefer for us to know we add jslibs that will not work with older versions. Even here I bump it quite a lot more than necesary - I think I only need v0.44.0 or something like this. Additioanlly our artefacts have the version so it is more involved to get the latest version. Arguably I would prefer this to run the last 4-5 versions or something like this. |
Yeah, if that's the purpose, similar to what we do with Go (std) or xk6 (Go) extensions, then I agree we could run them against a range of the X most recent versions, being X whatever we feel adequate, like 3? 5? 👍🏻 |
I opened #120 for now |
Description
Bump k6 to latest version
Please fill in this template.
npm run test
command succeeds.yarn run generate-homepage
locally and verify the new homepage/lib/index.html
file looks legit.Select one of these and delete the others:
If adding a new jslib:
/lib/{jslib_name}
folder./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle exists.supported.json
file to contain an entry for the newly added jslib and its{desired_version}
, as in the following example:/tests/basic.js
and/tests/testSuite.js
to ensure that the added jslib is importable and runnable by k6.If publishing a new version of an existing jslib:
version bump
label./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle.supported.json
file to contain an entry for the newly added jslib version, as in the following example:/tests/basic.js
and/tests/testSuite.js
files to ensure that the new version of the jslib is importable and runnable by k6.