Warning about minified code #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov,
oleiade,
w1kman and
e-fisher
and removed request for
a team
allansson
approved these changes
Jun 12, 2024
e-fisher
approved these changes
Jun 12, 2024
oleiade
approved these changes
Jun 12, 2024
codebien
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a warning that we don't accept external contributions that contain minified code.
Why?
After internal discussion, we decided that it is not safe to accept the minified code, and distribution of the changes in that case is the responsibility of the maintainer(s) who participated in the review.