Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http-instrumentation-pyroscope not using name tag #134

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

mstoykov
Copy link
Contributor

Description

the name tag was not accessed properly

Fix found by @andrewslotin

Please fill in this template.

  • Use a meaningful title for the Pull Request. Include the name of the jslib added/modified.
  • Fill the description section of the Pull Request.
  • Test the change in your code, and ensure the npm run test command succeeds.
  • Run yarn run generate-homepage locally and verify the new homepage /lib/index.html file looks legit.

Select one of these and delete the others:

If publishing a new version of an existing jslib:

  • The Pull Request is labeled with the version bump label.
  • The Pull Request adds a /lib/{jslib_name}/{desired_version} folder.
  • The Pull Request adds a /lib/{jslib_name}/{desired_version}/index.js file containing the jslib's code bundle.
  • The Pull Request updates the supported.json file to contain an entry for the newly added jslib version, as in the following example:
{
  "my-lib": [
    "1.0.2",
    // Use semantic versioning
    "{desired_version}"
  ]
}
  • The Pull Request adds the relevant tests to the /tests/basic.js and /tests/testSuite.js files to ensure that the new version of the jslib is importable and runnable by k6.
  • Merge the Pull Request once it is green. PRs adding new jslib versions do not require to get a review to be merged 🚀.

@mstoykov mstoykov requested review from a team as code owners July 18, 2024 10:30
@mstoykov mstoykov requested review from codebien, olegbespalov, w1kman and e-fisher and removed request for a team July 18, 2024 10:30
@github-actions github-actions bot requested review from legander and oleiade July 18, 2024 10:30
Copy link
Collaborator

@andrewslotin andrewslotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mstoykov
Copy link
Contributor Author

Technically we are supposed to bump the version and release a new one.

I am not certain it is worth it though, unfortunately I am also not certain that the caching will be update correctly too :(

@andrewslotin
Copy link
Collaborator

andrewslotin commented Jul 18, 2024

@mstoykov, let's bump the patch version to avoid any possible caching issues.

@mstoykov mstoykov added the bug Something isn't working label Jul 18, 2024
@mstoykov mstoykov requested a review from andrewslotin July 18, 2024 10:43
@mstoykov mstoykov merged commit 688a86a into main Jul 18, 2024
4 checks passed
@mstoykov mstoykov deleted the Fix-http-instrumentation-pyroscope branch July 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants