Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet another import case #85

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Yet another import case #85

merged 2 commits into from
Nov 30, 2022

Conversation

julienduchesne
Copy link
Member

This adds a new test case that (hopefully) contains all the ways to reference something by import
Fixed by doing recursive processing in a place where we weren't

@julienduchesne
Yet another import case not working
d2160ee 
This adds a new test case that (hopefully) contains all the ways to reference something by import
Fixed by doing recursive processing, I removed a "special" case to do so
jdbaldry
jdbaldry approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This looks reasonable to me but I've only looked at the patch and the test case in isolation from the rest of the code.

@julienduchesne julienduchesne merged commit f0d735b into main Nov 30, 2022
@julienduchesne julienduchesne deleted the julienduchesne/new-complex-import-case branch November 30, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbaldry jdbaldry jdbaldry approved these changes

@zzehring zzehring Awaiting requested review from zzehring zzehring is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @jdbaldry