Windows modular observ lib #1050

v-zhuravlev · 2023-08-30T13:50:56Z

cd windows-mixin
grr apply mixin.libsonnet

Checklist:

Changelog:

Create three-tier dashboards (Fleet->Overview->Advanced drill down, including logs), similar to node exporter dashboards
Introduced modular observ lib structure, that should make this lib highly customizable and reusable
Increase pending period for alerts to 15m to match linux
Add disk status alert
Add common annotations: reboot,failedService,criticalSystemEvent

Examples:
Fleet dash:

Overview dash:

Logs dash:

Disks dash:

rgeyer

Looks good overall. A few nits here and there.

Mostly, I think we should get the dependencies reviewed/merged before this is merged. What do you think?

rgeyer · 2023-10-04T21:30:14Z

windows-mixin/jsonnetfile.json

        }
      },
-      "version": "master"
+      "version": "vzhuravlev/jl-windows-new"


You'll want to have a follow-up PR to change this to master, or perhaps you can reference the specific commit SHA. I believe the branch usually gets deleted on merge.

rgeyer · 2023-10-04T21:39:10Z

windows-observ-lib/alerts.libsonnet

+    // TODO: add scheduled tasks failed alerts,
+    // time alerts, ntp delay alerts, disk running out of space predict alerts


Looks like these are all done, this can be removed?

Suggested change

// TODO: add scheduled tasks failed alerts,

// time alerts, ntp delay alerts, disk running out of space predict alerts

rgeyer · 2023-10-04T21:44:45Z

windows-observ-lib/dashboards.libsonnet

+                    // panels.systemThreads,
+                    // panels.systemExceptions,


Is there a problem with these? Should they also be removed from the windows-observ-lib?

Did this get discussed? :)

I'll check and make follow-up PR.

rgeyer · 2023-10-04T21:47:03Z

windows-observ-lib/jsonnetfile.json

+          "subdir": "common-lib"
+        }
+      },
+      "version": "vzhuravlev/common-lib"


Should this get merged first? Given it's a requirement, we should probably have that nailed down with some certainty that the interface will not change.

commonlib is ready for review. once we merge it, we can continue with windows lib.

rgeyer · 2023-10-04T21:48:58Z

windows-observ-lib/panels.libsonnet

+      systemExceptions:
+        commonlib.panels.all.timeSeries.base.new(
+          'System calls and exceptions',
+          targets=[
+            t.windowsSystemExceptions,
+            t.windowsSystemCalls,
+          ],
+        ),
+      systemThreads:
+        commonlib.panels.all.timeSeries.base.new(
+          'System threads',
+          targets=[
+            t.windowsSystemThreads,
+          ],
+        ),


Same question as in dashboards.libsonnet.. If these are unused, should they persist?

rgeyer · 2023-10-04T21:49:59Z

windows-observ-lib/panels.libsonnet

+          CPU usage by different modes.
+        |||
+      ),
+      // TODO add why it is important, consider alert


Seems like the description adequately explains why this metric is important?

Suggested change

// TODO add why it is important, consider alert

thnks, removed

rgeyer · 2023-10-04T21:51:39Z

windows-observ-lib/utils.libsonnet

@@ -0,0 +1,41 @@
+{


I think most of these are pretty common utils. I don't recall. Did we intend to merge these with grafonnet or with the common-lib?

Thnks, Moved to commonlib

windows-observ-lib/alerts.libsonnet

rgeyer

This looks ready to go!

I'd wait until common-lib is merged, and update that reference in jsonnet bundler, but otherwise. 🚀

Co-authored-by: Vitaly <v-zhuravlev@users.noreply.github.com>

Dasomeone · 2023-10-18T12:38:12Z

windows-observ-lib/README.md

+![image](https://github.com/grafana/jsonnet-libs/assets/14870891/b36b6245-643a-426f-9745-5437d93815ad)
+Overview dashboard:
+![image](https://github.com/grafana/jsonnet-libs/assets/14870891/723df88c-a789-4e73-a85e-724d9ea06cd2)
+Logs dashboard:
+![image](https://github.com/grafana/jsonnet-libs/assets/14870891/ec136706-96c1-4bc4-b608-f7184327d845)
+Drill down disks dashboard:
+![image](https://github.com/grafana/jsonnet-libs/assets/14870891/dfcda70d-4c2e-494f-b092-7d37a13d65d1)


These should probably be rehosted in our GCP cluster rather than github's CDN?

for integration, yes.

Dasomeone · 2023-10-18T12:39:31Z

windows-observ-lib/dashboards.libsonnet

+                    // panels.systemThreads,
+                    // panels.systemExceptions,


Did this get discussed? :)

v-zhuravlev requested a review from rgeyer September 6, 2023 18:31

v-zhuravlev force-pushed the vzhuravlev/jl-windows-new branch from 62d9e89 to ddacc8a Compare September 22, 2023 17:26

v-zhuravlev marked this pull request as ready for review September 22, 2023 17:26

v-zhuravlev changed the title ~~Windows modular mixin~~ Windows modular observ lib Sep 22, 2023

v-zhuravlev requested review from mshahzeb, gaantunes and Dasomeone September 22, 2023 18:20

v-zhuravlev force-pushed the vzhuravlev/jl-windows-new branch 5 times, most recently from 9446224 to 26b0127 Compare September 27, 2023 18:29

v-zhuravlev force-pushed the vzhuravlev/jl-windows-new branch from 235438d to b2e76d2 Compare October 3, 2023 14:52

gaantunes force-pushed the vzhuravlev/jl-windows-new branch from 5e6a8be to c961582 Compare October 4, 2023 20:48

rgeyer reviewed Oct 4, 2023

View reviewed changes

v-zhuravlev commented Oct 5, 2023

View reviewed changes

windows-observ-lib/alerts.libsonnet Outdated Show resolved Hide resolved

v-zhuravlev commented Oct 5, 2023

View reviewed changes

windows-observ-lib/alerts.libsonnet Outdated Show resolved Hide resolved

v-zhuravlev commented Oct 5, 2023

View reviewed changes

windows-observ-lib/alerts.libsonnet Outdated Show resolved Hide resolved

v-zhuravlev mentioned this pull request Oct 11, 2023

Integrations common lib #1028

Merged

v-zhuravlev requested a review from rgeyer October 16, 2023 18:10

rgeyer approved these changes Oct 17, 2023

View reviewed changes

v-zhuravlev added 9 commits October 18, 2023 19:29

Add initial structure for windows modular mixin

aeb5405

Add panels skeleton for main

1756c54

Update main

0b737c0

Update dashboards

39797eb

Add new targets and panels

ac17aae

Add more panels and targets

77121c1

Update to remote

e4d13b8

Add overview panels and targets

6356289

Fix to work with latest grafonnet

e4f7067

v-zhuravlev and others added 23 commits October 18, 2023 19:29

Fix customAllValue

ebe8e0a

Fix commonlib import

30da9a6

Update jsonnet dep

57877a6

Update panels

b57302d

Update version

3841f9a

Fmt

b9708d4

Add time collector tip in ntp panels

1ceebde

Revert commonlib link

d4f3351

Adding NTP alerts.

e38a7fd

Adding time offset alert

d66f682

Move utils to commonlib

9ca1340

Suggestions from Vitaly

409ce6a

Co-authored-by: Vitaly <v-zhuravlev@users.noreply.github.com>

removing service not running metric.w

cb2e270

lint fix

e384c2b

Update variables

b319c4a

Remove TODO notes

e30cf6f

Rename 'all' to 'generic'

77994b1

Rename to generic 2

e87b429

Remove redundant uid

6d58b00

Drop unused label from reboot annotation

6fb794e

Update observ lib 'schema'

4332de9

Update jsonnet deps to main

c07cc92

Update regex

1d0eb76

v-zhuravlev force-pushed the vzhuravlev/jl-windows-new branch from ecb0fc2 to 1d0eb76 Compare October 18, 2023 11:29

v-zhuravlev enabled auto-merge (squash) October 18, 2023 11:29

v-zhuravlev merged commit d2347c7 into master Oct 18, 2023

v-zhuravlev deleted the vzhuravlev/jl-windows-new branch October 18, 2023 11:30

Dasomeone reviewed Oct 18, 2023

View reviewed changes

v-zhuravlev mentioned this pull request Nov 9, 2023

Add node-observ-lib grafana/node_exporter#25

Merged

v-zhuravlev mentioned this pull request Nov 29, 2023

Refactor node-mixin as node-observ-lib prometheus/node_exporter#2861

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows modular observ lib #1050

Windows modular observ lib #1050

v-zhuravlev commented Aug 30, 2023 •

edited

Loading

rgeyer left a comment

rgeyer Oct 4, 2023

rgeyer Oct 4, 2023

rgeyer Oct 4, 2023

Dasomeone Oct 18, 2023

v-zhuravlev Oct 18, 2023

rgeyer Oct 4, 2023

v-zhuravlev Oct 11, 2023

rgeyer Oct 4, 2023

rgeyer Oct 4, 2023

v-zhuravlev Oct 11, 2023

rgeyer Oct 4, 2023

v-zhuravlev Oct 11, 2023

rgeyer left a comment

Dasomeone Oct 18, 2023

v-zhuravlev Oct 18, 2023

Dasomeone Oct 18, 2023

		// TODO: add scheduled tasks failed alerts,
		// time alerts, ntp delay alerts, disk running out of space predict alerts

Windows modular observ lib #1050

Windows modular observ lib #1050

Conversation

v-zhuravlev commented Aug 30, 2023 • edited Loading

rgeyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgeyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

v-zhuravlev commented Aug 30, 2023 •

edited

Loading