Add SNMPRestarted alert #1279
Merged
Add SNMPRestarted alert #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would increase it to 300 as you might miss that small uptime, due to scrape frequency (once in a minute?) |
v-zhuravlev
reviewed
Jul 12, 2024
snmp-mixin/alerts/alerts.libsonnet
Outdated
| alert: 'SNMPRestarted', | ||
| expr: 'sysUpTime < 60', | ||
| labels: { | ||
| severity: 'warning', |
There was a problem hiding this comment.
Suggested change
| severity: 'warning', | |
| severity: 'warning', |
I would set it to info, as you don't know if restart is planned or not. Also, boot from power off state would also fire it, I would set it to info.
v-zhuravlev
reviewed
Jul 12, 2024
snmp-mixin/alerts/alerts.libsonnet
Outdated
| summary: 'SNMP Target Restarted', | ||
| description: 'The SNMP target on instance {{$labels.instance}} from job {{$labels.job}} has restarted (sysUpTime < 60 seconds).', | ||
| }, | ||
| 'for': '1m', |
There was a problem hiding this comment.
I'm not sure if there is a point waiting here.
There was a problem hiding this comment.
Havent completely removed it - added a 5s wait instead
v-zhuravlev
reviewed
Jul 12, 2024
snmp-mixin/alerts/alerts.libsonnet
Outdated
| severity: 'warning', | ||
| }, | ||
| annotations: { | ||
| summary: 'SNMP Target Restarted', |
There was a problem hiding this comment.
Suggested change
| summary: 'SNMP Target Restarted', | |
| summary: 'SNMP target restarted', |
according to our style guide.
v-zhuravlev
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an alert to detect SNMP restart.