chore: move jaeger agent mixin #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have never ended up in ksonnet-util.
malcolmholmes
approved these changes
Jul 19, 2020
Duologic
added a commit
to grafana/loki
that referenced
this pull request
Jul 20, 2020
lib got moved: grafana/jsonnet-libs#291 used jb-0.4.0 which updates the jsonnetfile.json format
Duologic
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Jul 20, 2020
lib got moved: grafana/jsonnet-libs#291 used jb-0.4.0 which updates the jsonnetfile.json format
owen-d
pushed a commit
to grafana/loki
that referenced
this pull request
Jul 20, 2020
* refactor: use jaeger-agent-mixin lib got moved: grafana/jsonnet-libs#291 used jb-0.4.0 which updates the jsonnetfile.json format * refactor: use jb-0.4.0 jsonnetfile.json format
4 tasks
jeschkies
pushed a commit
that referenced
this pull request
Dec 9, 2020
…ting (#291) If exporter is scraped by multiple Prometheuses (as we do) - Collect() could be called concurrently. In result in some cases one of Prometheuses could get pg_up = 0, because it was explicitly set to zero on first Collect call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have never ended up in ksonnet-util.
ref: #215