Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing options.cloud #1525

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Introducing options.cloud #1525

merged 1 commit into from
Mar 20, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 15, 2024

What?

This PR documents the options.cloud introduced in grafana/k6#3348

I'm unsure if we should still promote ext; that's why I replaced it.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/k6#3348

@olegbespalov olegbespalov requested a review from a team March 15, 2024 15:45
@olegbespalov olegbespalov self-assigned this Mar 15, 2024
@olegbespalov olegbespalov requested review from oleiade and joanlopez and removed request for a team March 15, 2024 15:45
@olegbespalov olegbespalov mentioned this pull request Mar 15, 2024
28 tasks
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, overall it looks good! I'll take a look at the Grafana Cloud k6 docs as well and see if there are any updates we need to make there.

@@ -352,13 +352,13 @@ export const options = {

{{< /code >}}

## Extension options
## Cloud options

An object used to set configuration options for cloud parameters and third-party collectors, like plugins. For more information about available parameters, refer to [Cloud options](https://grafana.com/docs/grafana-cloud/k6/author-run/cloud-scripting-extras/cloud-options/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olegbespalov, I saw you removed "third-party collectors" from the table above. Do we want to remove it from here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it makes sense to remove this from here, good catch 👍 I'll open a PR

@oleiade
Copy link
Member

oleiade commented Mar 20, 2024

As Oleg is away this week, I'll merge this to avoid blocking the release process 🙇‍♂️

@oleiade oleiade merged commit 4b0b991 into main Mar 20, 2024
5 checks passed
@oleiade oleiade deleted the feat/options-cloud branch March 20, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants