-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing options.cloud #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, overall it looks good! I'll take a look at the Grafana Cloud k6 docs as well and see if there are any updates we need to make there.
@@ -352,13 +352,13 @@ export const options = { | |||
|
|||
{{< /code >}} | |||
|
|||
## Extension options | |||
## Cloud options | |||
|
|||
An object used to set configuration options for cloud parameters and third-party collectors, like plugins. For more information about available parameters, refer to [Cloud options](https://grafana.com/docs/grafana-cloud/k6/author-run/cloud-scripting-extras/cloud-options/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olegbespalov, I saw you removed "third-party collectors" from the table above. Do we want to remove it from here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it makes sense to remove this from here, good catch 👍 I'll open a PR
As Oleg is away this week, I'll merge this to avoid blocking the release process 🙇♂️ |
What?
This PR documents the
options.cloud
introduced in grafana/k6#3348I'm unsure if we should still promote ext; that's why I replaced it.
Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)
grafana/k6#3348