fix: Use standard naming for nodeSelector definition #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
|
|
JorTurFer
changed the title
yorugac
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Hi @JorTurFer, thanks for the PR! LGTM 👍
In this case, I think let's change it as is, as breaking change, since it's basically a result of typo; I'd prefer not to support nodeselector long-term.
yorugac
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was exposed here,
nodeselectoruses wrong notation and breaks with Kubernetes standard naming. This PR renames the section tonodeSelectorThis is a breaking change, if you want to maintain backward compatibility, I can update the PR adding support to both and a deprecation message on the wrong one
Fixes #206