Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finished state change and clean up post execution #79

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Add finished state change and clean up post execution #79

merged 2 commits into from
Feb 11, 2022

Conversation

brian-groux-hs
Copy link
Contributor

No description provided.

@brian-groux-hs
Copy link
Contributor Author

Some sample output from the controller during a test run

2021-10-22T18:16:15.230Z	INFO	controllers.K6	1/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:16:15.230Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:40.399Z	INFO	controllers.K6	2/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:40.399Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:44.452Z	INFO	controllers.K6	3/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:44.452Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:48.478Z	INFO	controllers.K6	4/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:48.478Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:51.522Z	INFO	controllers.K6	5/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:51.522Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:55.575Z	INFO	controllers.K6	6/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:55.575Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:18:59.603Z	INFO	controllers.K6	7/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:18:59.603Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:19:04.695Z	INFO	controllers.K6	8/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:19:04.695Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:19:08.706Z	INFO	controllers.K6	9/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:19:08.706Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:19:11.747Z	INFO	controllers.K6	10/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:19:11.747Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:19:15.790Z	INFO	controllers.K6	11/11 jobs complete	{"k6": "monitoring/k6-load-test-example"}
2021-10-22T18:19:15.803Z	DEBUG	controller	Successfully Reconciled	{"reconcilerGroup": "k6.io", "reconcilerKind": "K6", "controller": "k6", "name": "k6-load-test-example", "namespace": "monitoring"}
2021-10-22T18:19:15.804Z	INFO	controllers.K6	Cleaning up all resources	{"k6": "monitoring/k6-load-test-example"}

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yorugac
yorugac requested changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brian-groux-hs,
Thank you for your contribution! I've tested it locally for a bit. There was one funny case with how jobs are counted -- I've described it in the comment. But otherwise, it seems to work as expected ⭐

I have just two small change requests: one to have a clean merge into main and one about renaming function & file; please see the comments.

api/v1alpha1/zz_generated.deepcopy.go Show resolved Hide resolved
controllers/k6_controller.go Outdated Show resolved Hide resolved
controllers/k6_reconcile.go Outdated Show resolved Hide resolved
@yorugac yorugac mentioned this pull request Dec 20, 2021
Closed
@brian-groux-hs
Copy link
Contributor Author

@yorugac Made requested changes

@yorugac yorugac self-requested a review February 10, 2022 14:44
yorugac
yorugac approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @brian-groux-hs! LGTM 🙂

@yorugac yorugac merged commit 46fb8e3 into grafana:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorugac yorugac yorugac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-groux-hs @CLAassistant @yorugac