fix: disable window reloading in prod build #275
Merged
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
requested review from
going-confetti,
e-fisher and
allansson
and removed request for
a team
|
|
||
| function getDevToolsMenu(): Electron.MenuItemConstructorOptions[] { | ||
| return isDevEnv | ||
| ? [{ role: 'reload' }, { role: 'forceReload' }, { role: 'toggleDevTools' }] |
There was a problem hiding this comment.
Shortcuts are bound with the application menu. Here, we can conditionally remove them from prod mode.
cristianoventura
changed the title
Co-authored-by: Edgar Fisher <fisher.edgar@gmail.com>
e-fisher
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some properties from the application menu as long as their key bindings, including:
CMD + RCMD + Shift + RCMD + Option + IHow to Test
NODE_ENVvariable in your localhost and check thatCMD + Rand other shortcuts mentioned above no longer workChecklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #274