Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intel mac app #420

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: intel mac app #420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b198217
fix: intel mac app
Llandy3d Jan 16, 2025
c0e8bde
fix: intel mac app
Llandy3d Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,29 @@ jobs:
env:
WINDOWS_CERTIFICATE: ${{ secrets.WINDOWS_CERTIFICATE }}

- name: publish
- name: publish macOS
if: startsWith(matrix.platform, 'macos-')
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# notarization
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
APPLE_API_KEY: ./apple_api_key.p8
# sentry integration
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
# sentry vite plugin integration during build
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ORG: ${{ env.SENTRY_ORG }}
SENTRY_PROJECT: ${{ env.SENTRY_PROJECT }}
run: |
# on macos we also build the x64 app separately
npm run publish -- --arch=x64
npm run publish

- name: publish Windows
if: startsWith(matrix.platform, 'windows-')
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# windows cert
WINDOWS_CERTIFICATE_PATH: ./certificate.pfx
WINDOWS_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}
Expand Down
Loading