Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview form data payload in a table #92

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

e-fisher
Copy link
Collaborator

@e-fisher e-fisher commented Aug 9, 2024

Reported by Tom:

application/x-www-form-urlencoded POST data are being rendered as JSON in the payload tab. Ideally they would appear much like how we render headers i.e. table style

Render x-www-form-urlencoded payload as table

Before:

CleanShot 2024-08-09 at 14 00 05@2x

After
CleanShot 2024-08-09 at 13 48 38@2x

@e-fisher e-fisher requested review from 2Steaks and Llandy3d August 9, 2024 11:02
try {
return JSON.parse(value)
return JSON.parse(value) as T
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the function would return any and typescript didn't recognize the return value could be undefined

@e-fisher e-fisher marked this pull request as ready for review August 9, 2024 11:04
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@e-fisher
Copy link
Collaborator Author

e-fisher commented Aug 9, 2024

Merging this with one approval since my next task depends on it, @going-confetti feel free to comment if something doesn't look right, and I'll address it in a separate PR

@e-fisher e-fisher merged commit d0dd57a into main Aug 9, 2024
1 check passed
@e-fisher e-fisher deleted the fix/form-payload-preview branch August 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants