Fix json bug by reusing pointers

grafana · Dec 4, 2019 · 45fef98 · 45fef98
1 parent 6a552ad
commit 45fef98
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/js/modules/k6/http/request.go b/js/modules/k6/http/request.go
@@ -358,10 +358,10 @@ func (h *HTTP) parseRequest(
 
 func (h *HTTP) prepareBatchArray(
 	ctx context.Context, requests []interface{},
-) ([]httpext.BatchParsedHTTPRequest, []Response, error) {
+) ([]httpext.BatchParsedHTTPRequest, []*Response, error) {
 	reqCount := len(requests)
 	batchReqs := make([]httpext.BatchParsedHTTPRequest, reqCount)
-	results := make([]Response, reqCount)
+	results := make([]*Response, reqCount)
 
 	for key, req := range requests {
 		parsedReq, err := h.parseBatchRequest(ctx, key, req)
@@ -373,18 +373,18 @@ func (h *HTTP) prepareBatchArray(
 			ParsedHTTPRequest: parsedReq,
 			Response:          response,
 		}
-		results[key] = Response{response}
+		results[key] = &Response{response}
 	}
 
 	return batchReqs, results, nil
 }
 
 func (h *HTTP) prepareBatchObject(
 	ctx context.Context, requests map[string]interface{},
-) ([]httpext.BatchParsedHTTPRequest, map[string]Response, error) {
+) ([]httpext.BatchParsedHTTPRequest, map[string]*Response, error) {
 	reqCount := len(requests)
 	batchReqs := make([]httpext.BatchParsedHTTPRequest, reqCount)
-	results := make(map[string]Response, reqCount)
+	results := make(map[string]*Response, reqCount)
 
 	i := 0
 	for key, req := range requests {
@@ -397,7 +397,7 @@ func (h *HTTP) prepareBatchObject(
 			ParsedHTTPRequest: parsedReq,
 			Response:          response,
 		}
-		results[key] = Response{response}
+		results[key] = &Response{response}
 		i++
 	}