-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check samples in TestDNSResolver instead of log messages
This should hopefully be more reliable, and avoid the flakiness we've seen on Windows[1], even after #1974: scheduler_ext_test.go:1130: Error Trace: D:/a/k6/k6/execution/scheduler_ext_test.go:1130 Error: Should be true Test: TestDNSResolver/cache/3s Messages: expected error to contain one of the list of messages It doesn't get rid of the reliance on timings, but since the way we check DNS TTL also relies on time, we can't easily avoid it. Maybe by switching to the MiniRunner instead of js.Runner we could avoid the sleep() in the script, but the value of this test is also calling the k6/http module directly, so it's closer to a real world script.
- Loading branch information
Ivan Mirić
committed
May 23, 2023
1 parent
bb7a7d1
commit a76c8ab
Showing
2 changed files
with
34 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters