Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve executor/scenario configs #1427

Open
na-- opened this issue Apr 30, 2020 · 3 comments
Open

Improve executor/scenario configs #1427

na-- opened this issue Apr 30, 2020 · 3 comments

Comments

@na--
Copy link
Member

na-- commented Apr 30, 2020

As seen in #1419, sometimes it would be ideal to pre-calculate some execution segment sequences and reuse them, both in the executor/scenario description, as well as in the actual test execution. Now we don't have any mechanism to do that, so we probably should add some hook that gets called before (or maybe after) the validation.

Another issue that would probably benefit from that is #1317

@mstoykov
Copy link
Collaborator

in order for #1525 to work it required to change the config in the Validate function, which shouldn't really change the configuration

na-- added a commit that referenced this issue Jul 6, 2020
This was an initial attempt to solve the first point from #1514, but there were a few blockers:
- #1499
- #1427
- #1386 (comment)
@na--
Copy link
Member Author

na-- commented Jul 6, 2020

As mentioned in #1514 (comment) and ee17425, the current re-segmentation has some issues, especially when it comes to the shared-iterations executor.

Fairer re-segmentation is needed, since the current one (based on the striping algorithm) doesn't deal well with small numbers. Running k6-1007 run --vus 2 --iterations 2 --execution-segment 0:1/100 --execution-segment-sequence=0,1/100,1 github.com/loadimpact/k6/samples/http_get.js will result in a 1VU/1iteration test run. So, 1% of the test run would be equal to the other 99%, which is obviously not ideal. We should be safe to leave it as it is for v0.27.0, since it only affects small numbers, but as demonstrated in the commit above, fixing it should be relatively easy and clean once we have the proper abstractions...

@imiric
Copy link
Contributor

imiric commented Jul 6, 2020

Another cleanup reminder (see #1490 (review)): printExecutionDescription() was added to unify the execution description output for both local and cloud execution, but it could use a more integrated approach.

@na-- na-- modified the milestones: v0.28.0, v0.29.0 Sep 9, 2020
@na-- na-- modified the milestones: v0.29.0, v0.31.0 Nov 3, 2020
@na-- na-- modified the milestones: v0.31.0, v1.0.0 Feb 24, 2021
@na-- na-- modified the milestones: v1.0.0, TBD Nov 9, 2022
@codebien codebien removed this from the TBD milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants