-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console
shouldn't use os
package directly
#2565
Labels
Comments
console
uses os
package directlyconsole
shouldn't use os
package directly
vanshaj
added a commit
to vanshaj/k6
that referenced
this issue
Jul 31, 2022
For the record. After an internal discussion, we decided to clean a milestone since the issue was jumping between milestones without completion. Once we determine which milestone it lands, we set the right one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
js/console.go uses directly the
os
package while almost everything uses an abstraction such asafero
We should be using afero across everything (until #1079) so this needs to change.
This likely can be done similarly to #2487
The text was updated successfully, but these errors were encountered: