Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set the "name" of scripts ran through the shortcut urls #1237

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 12, 2019

fixes #1236

Text for release notes in bugfix section:

Cloud output: correctly set the "name" for scripts being ran through the shortcut urls (github.com,cdnjs.com), instead of returning an error. Thanks @Menda for reporting! (#1237)

cuonglm
cuonglm previously approved these changes Nov 12, 2019
@mstoykov mstoykov added this to the v0.26.0 milestone Nov 12, 2019
@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #1237 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
- Coverage   75.35%   75.29%   -0.06%     
==========================================
  Files         147      147              
  Lines       10711    10711              
==========================================
- Hits         8071     8065       -6     
- Misses       2177     2182       +5     
- Partials      463      464       +1
Impacted Files Coverage Δ
stats/cloud/collector.go 76.99% <100%> (-1.23%) ⬇️
core/engine.go 93.77% <0%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24d8f9...7ace888. Read the comment docs.

na--
na-- previously approved these changes Nov 13, 2019
@mstoykov mstoykov dismissed stale reviews from na-- and cuonglm via 7ace888 November 13, 2019 07:19
@mstoykov mstoykov merged commit 82d6dd4 into master Nov 13, 2019
@mstoykov mstoykov deleted the fixNameWhenOutputingToCloud branch November 13, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k6 run -o cloud does not work with scripts from shortcut URLs
5 participants