Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with the linux package builds and the README #1276

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

na--
Copy link
Member

@na-- na-- commented Dec 16, 2019

This is just a collection of short-term fixes:

  • pin the latest .msi package in the README, instead of using a specific version
  • use go get -d for the go-bin-deb and go-bin-rpm packages, to only download the source (without building them) before we use glide to get their precise dependencies
  • inject the new full version information in the build process

As mentioned in #1247 (comment), we should build and test the linux packages regularly, so we can fix them if something breaks...

This is just a collection of short-term fixes:
- pin the latest .msi package in the README, instead of using a specific version
- use `go get -d` for the go-bin-deb and go-bin-rpm packages, to only download the source (without building them) before we use glide to get their precise dependencies
- inject the new full version information in the build process

As mentioned in #1247 (comment), we should build and test the linux packages regularly, so we can fix them if something breaks...
imiric
imiric previously approved these changes Dec 16, 2019
@imiric
Copy link
Contributor

imiric commented Dec 16, 2019

I would like to version pin both go-bin-* tools, but that can be done later if we decide to keep using them.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #1276 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   75.43%   75.42%   -0.02%     
==========================================
  Files         150      150              
  Lines       10883    10883              
==========================================
- Hits         8210     8208       -2     
- Misses       2207     2209       +2     
  Partials      466      466
Impacted Files Coverage Δ
stats/cloud/collector.go 76.99% <0%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeec9a7...ba5bcea. Read the comment docs.

release notes/v0.26.0.md Outdated Show resolved Hide resolved
imiric
imiric previously approved these changes Dec 16, 2019
@na--
Copy link
Member Author

na-- commented Dec 16, 2019

I would like to version pin both go-bin-* tools

Yeah, if we decide to stick with them, we should pin them. The only reason we haven't had an issue so far has been the lack of activity in their repos... At this point, I am so fed up with our CI issues, that I want to use #959 for a total overhaul of everything...

We should start from the ground-up and build everything in a robust manner, fixing all of the many issues we've seen with the current setup... The manual build-release.sh and homebrew bump, #1247, #1034, #902, #1230, #342, #903, #901, #919, maybe even #1167...

@na-- na-- merged commit de39513 into master Dec 16, 2019
@na-- na-- deleted the post-release-fixes branch December 16, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants