-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with the linux package builds and the README #1276
Conversation
This is just a collection of short-term fixes: - pin the latest .msi package in the README, instead of using a specific version - use `go get -d` for the go-bin-deb and go-bin-rpm packages, to only download the source (without building them) before we use glide to get their precise dependencies - inject the new full version information in the build process As mentioned in #1247 (comment), we should build and test the linux packages regularly, so we can fix them if something breaks...
I would like to version pin both |
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 75.43% 75.42% -0.02%
==========================================
Files 150 150
Lines 10883 10883
==========================================
- Hits 8210 8208 -2
- Misses 2207 2209 +2
Partials 466 466
Continue to review full report at Codecov.
|
Yeah, if we decide to stick with them, we should pin them. The only reason we haven't had an issue so far has been the lack of activity in their repos... At this point, I am so fed up with our CI issues, that I want to use #959 for a total overhaul of everything... We should start from the ground-up and build everything in a robust manner, fixing all of the many issues we've seen with the current setup... The manual |
9aa50ef
to
ba5bcea
Compare
This is just a collection of short-term fixes:
go get -d
for the go-bin-deb and go-bin-rpm packages, to only download the source (without building them) before we use glide to get their precise dependenciesAs mentioned in #1247 (comment), we should build and test the linux packages regularly, so we can fix them if something breaks...