Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test fixes part2 #1568

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Flaky test fixes part2 #1568

merged 3 commits into from
Jul 22, 2020

Conversation

mstoykov
Copy link
Collaborator

One more batch of changes for #1357

@mstoykov mstoykov added this to the v0.27.1 milestone Jul 21, 2020
@mstoykov mstoykov requested review from imiric and na-- July 21, 2020 15:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #1568 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
- Coverage   77.11%   77.09%   -0.02%     
==========================================
  Files         162      162              
  Lines       13192    13192              
==========================================
- Hits        10173    10171       -2     
- Misses       2499     2501       +2     
  Partials      520      520              
Impacted Files Coverage Δ
lib/executor/vu_handle.go 95.49% <0.00%> (-0.91%) ⬇️
lib/executor/constant_arrival_rate.go 96.75% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d5ee7...f1090b8. Read the comment docs.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to tell from timing changes whether this is a definitive fix 😄

We might need some refactoring in how they work and maybe trying one of the time mocking packages after all. 😕

@mstoykov mstoykov merged commit 5ff4a76 into master Jul 22, 2020
@mstoykov mstoykov deleted the flakyTestFixesPart2 branch July 22, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants