Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs with output configs #1881

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Fix bugs with output configs #1881

merged 2 commits into from
Mar 4, 2021

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 4, 2021

No description provided.

@na-- na-- added this to the v0.31.0 milestone Mar 4, 2021
@na-- na-- requested review from mstoykov and imiric March 4, 2021 11:15
mstoykov
mstoykov previously approved these changes Mar 4, 2021
View reviewed changes
imiric
imiric reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think 😅

cloudapi/config_test.go Show resolved Hide resolved
@na-- na-- merged commit a44f5dc into master Mar 4, 2021
@na-- na-- deleted the fix-outputs branch March 4, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@na-- @mstoykov @imiric